Skip to content

chore(api): expose attribute context in endpoint - #127372

Merged
lzhao-sentry merged 2 commits into
masterfrom
lzhao/chore/expose-attribute-context
Oct 15, 2026
Merged

lzhao-sentry merged 2 commits into
masterfrom
lzhao/chore/expose-attribute-context

Conversation

@lzhao-sentry

@lzhao-sentry lzhao-sentry commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Changes

Addresses EXP-1293 by letting context be exposed so CLI can access it

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

EXP-1293

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 14, 2026
@lzhao-sentry
lzhao-sentry marked this pull request as ready for review October 14, 2026 14:08
@lzhao-sentry
lzhao-sentry requested a review from a team as a code owner October 14, 2026 14:09

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1add095. Configure here.

@skaasten

Copy link
Copy Markdown
Contributor

If we're now showing in public docs, can we mark it as "experimental" in the description like we do other apis that are still in development?

@lzhao-sentry
lzhao-sentry marked this pull request as draft October 14, 2026 14:34
@lzhao-sentry

Copy link
Copy Markdown
Member Author

Turning back to draft and checking if we can just update CLI directly to expose the context

exclude=True,
# The endpoint is PUBLIC, but the context shape is still evolving, so only this
# parameter is flagged experimental.
extensions={"x-sentry-experimental": True},

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if is this extensions part is needed, but I can remove it and the unit test if it suffices to just update the description

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is doing anything today, but we probably should use it so worth adding still

@lzhao-sentry
lzhao-sentry marked this pull request as ready for review October 14, 2026 18:17

@wmak wmak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I might follow up with a change to make marking parameters as experimental cleaner

exclude=True,
# The endpoint is PUBLIC, but the context shape is still evolving, so only this
# parameter is flagged experimental.
extensions={"x-sentry-experimental": True},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is doing anything today, but we probably should use it so worth adding still

@lzhao-sentry
lzhao-sentry merged commit 4c5a4db into master Oct 15, 2026
71 of 72 checks passed
@lzhao-sentry
lzhao-sentry deleted the lzhao/chore/expose-attribute-context branch October 15, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants