Skip to content

chore(combinators): Add more data to log - #127383

Merged
wmak merged 1 commit into
masterfrom
wmak/chore/add-column-to-log
Oct 14, 2026
Merged

wmak merged 1 commit into
masterfrom
wmak/chore/add-column-to-log

Conversation

@wmak

@wmak wmak commented Oct 14, 2026

Copy link
Copy Markdown
Member
  • Want some more additional data

- Want some more additional data
@wmak
wmak requested a review from a team as a code owner October 14, 2026 15:25
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 14, 2026
Comment on lines +1332 to +1333
"column": column,
"query_string": self.params.query_string,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raw EAP query and aggregate expression copied into a warning log

When resolving a deprecated aggregate fails, the warning log includes the raw query_string and full column expression. These request values can contain real user identifiers—for example, searches against EAP fields such as user.email or user.ip, or literal values in conditional aggregate expressions. Redact or omit these values; retain only non-identifying diagnostic fields such as the function name and organization ID.

Evidence
  • OrganizationEvents constructs SnubaParams with query_string=query from the request (src/sentry/api/bases/organization_events.py:201-212), so this parameter can contain user-supplied search terms.
  • get_table_rpc_request() passes request filters and selected columns through SearchResolver (src/sentry/snuba/rpc_dataset_common.py:279-282); the resolver logs when resolution of a deprecated function raises (src/sentry/search/eap/resolver.py:1322-1334).
  • The warning’s structured extra includes both raw values, without redaction; EAP exposes searchable user.email, user.ip, user.id, and user.username attributes (src/sentry/search/eap/spans/attributes.py:564-572).
  • These values are request data, not synthetic examples or author metadata, and the warning sends them to the application logging sink.

Identified by Warden · wrdn-pii · R4T-XAM

@wmak
wmak merged commit b952d05 into master Oct 14, 2026
81 checks passed
@wmak
wmak deleted the wmak/chore/add-column-to-log branch October 14, 2026 18:38
adrianviquez pushed a commit that referenced this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants