Repository navigation
chore(combinators): Add more data to log - #127383
Merged
Merged
Conversation
wmak
commented
Oct 14, 2026
Member
- Want some more additional data
- Want some more additional data
Comment on lines
+1332
to
+1333
| "column": column, | ||
| "query_string": self.params.query_string, |
Contributor
There was a problem hiding this comment.
Raw EAP query and aggregate expression copied into a warning log
When resolving a deprecated aggregate fails, the warning log includes the raw query_string and full column expression. These request values can contain real user identifiers—for example, searches against EAP fields such as user.email or user.ip, or literal values in conditional aggregate expressions. Redact or omit these values; retain only non-identifying diagnostic fields such as the function name and organization ID.
Evidence
OrganizationEventsconstructsSnubaParamswithquery_string=queryfrom the request (src/sentry/api/bases/organization_events.py:201-212), so this parameter can contain user-supplied search terms.get_table_rpc_request()passes request filters and selected columns throughSearchResolver(src/sentry/snuba/rpc_dataset_common.py:279-282); the resolver logs when resolution of a deprecated function raises (src/sentry/search/eap/resolver.py:1322-1334).- The warning’s structured
extraincludes both raw values, without redaction; EAP exposes searchableuser.email,user.ip,user.id, anduser.usernameattributes (src/sentry/search/eap/spans/attributes.py:564-572). - These values are request data, not synthetic examples or author metadata, and the warning sends them to the application logging sink.
Identified by Warden · wrdn-pii · R4T-XAM
k-fish
approved these changes
Oct 14, 2026
adrianviquez
pushed a commit
that referenced
this pull request
Oct 14, 2026
- Want some more additional data
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.