Repository navigation
test(issues): Wait for bookmark update before checking the API - #127394
Merged
Merged
Conversation
The bookmark menu item flips to "unbookmark" optimistically, so test_bookmark could read the issue from the API before the PUT landed and see isBookmarked false. Wait for the "Issue bookmarked" toast, which only shows after the request succeeds. Same fix #126309 made for resolve and archive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scttcper
marked this pull request as ready for review
October 14, 2026 16:52
roggenkemper
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_bookmark flakes because the bookmark menu item flips to "unbookmark" optimistically, so the test can read the issue from the API before the PUT lands. Waits for the "Issue bookmarked" toast instead, which only shows after the request succeeds.
Same fix as #126309 for resolve and archive.
fixes SENTRY-TESTS-1DH4