Skip to content

test(issues): Wait for bookmark update before checking the API - #127394

Merged
scttcper merged 1 commit into
masterfrom
scttcper/fix-bookmark-flake
Oct 14, 2026
Merged

scttcper merged 1 commit into
masterfrom
scttcper/fix-bookmark-flake

Conversation

@scttcper

Copy link
Copy Markdown
Member

test_bookmark flakes because the bookmark menu item flips to "unbookmark" optimistically, so the test can read the issue from the API before the PUT lands. Waits for the "Issue bookmarked" toast instead, which only shows after the request succeeds.

Same fix as #126309 for resolve and archive.

fixes SENTRY-TESTS-1DH4

The bookmark menu item flips to "unbookmark" optimistically, so
test_bookmark could read the issue from the API before the PUT landed
and see isBookmarked false. Wait for the "Issue bookmarked" toast, which
only shows after the request succeeds.

Same fix #126309 made for resolve and archive.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@scttcper
scttcper marked this pull request as ready for review October 14, 2026 16:52
@scttcper scttcper changed the title fix(acceptance): Wait for bookmark update before checking the API fix(issues): Wait for bookmark update before checking the API Oct 14, 2026
@scttcper
scttcper requested a review from a team October 14, 2026 16:53
@scttcper scttcper changed the title fix(issues): Wait for bookmark update before checking the API test(issues): Wait for bookmark update before checking the API Oct 14, 2026
@scttcper
scttcper enabled auto-merge (squash) October 14, 2026 16:56
@scttcper
scttcper merged commit e93be7c into master Oct 14, 2026
72 checks passed
@scttcper
scttcper deleted the scttcper/fix-bookmark-flake branch October 14, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants