Skip to content

fix(derived data): Filter out very recently backfilled actions in consistency check - #127402

Merged
kcons merged 2 commits into
masterfrom
kcons/morecareful
Oct 14, 2026
Merged

kcons merged 2 commits into
masterfrom
kcons/morecareful

Conversation

@kcons

@kcons kcons commented Oct 14, 2026

Copy link
Copy Markdown
Member

In order to make our consistency check metrics more reliable indicators, we need to deal with a known noisy case.
When we're doing backfills (rare though they are) we typically insert all the backfill rows and invalidate afterward, leading to a small window where there's a legitimate and benign inconsistency.
Rather than allowing inconsistency metrics to reflect that (accurate, but not useful), this adds a 10min settle window, such that if the log contains anything written in the last 10 minutes, we consider it neither success nor failure.
This should make our inconsistency metrics reliable enough to alert on.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 14, 2026
@kcons

kcons commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

bugbot review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit c86156e. Configure here.

@kcons
kcons marked this pull request as ready for review October 14, 2026 17:41
@kcons
kcons requested review from a team as code owners October 14, 2026 17:41
@kcons kcons changed the title fix(derived data): Filter out very recent logs in consistency check fix(derived data): Filter out very recently backfilled actions in consistency check Oct 14, 2026

@yuvmen yuvmen left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@kcons
kcons merged commit 6baf64e into master Oct 14, 2026
75 checks passed
@kcons
kcons deleted the kcons/morecareful branch October 14, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants