Repository navigation
fix(derived data): Filter out very recently backfilled actions in consistency check - #127402
Merged
Merged
Conversation
Member
Author
|
bugbot review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c86156e. Configure here.
kcons
marked this pull request as ready for review
October 14, 2026 17:41
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make our consistency check metrics more reliable indicators, we need to deal with a known noisy case.
When we're doing backfills (rare though they are) we typically insert all the backfill rows and invalidate afterward, leading to a small window where there's a legitimate and benign inconsistency.
Rather than allowing inconsistency metrics to reflect that (accurate, but not useful), this adds a 10min settle window, such that if the log contains anything written in the last 10 minutes, we consider it neither success nor failure.
This should make our inconsistency metrics reliable enough to alert on.