Repository navigation
ref(api): Clarify why performance general settings endpoint is private - #127420
Merged
DominikB2014 merged 1 commit intoOct 23, 2026
Merged
DominikB2014 merged 1 commit into
DominikB2014 merged 1 commit into
Conversation
Co-Authored-By: Dominik Buszowiecki <44422760+DominikB2014@users.noreply.github.com>
cvxluo
approved these changes
Oct 15, 2026
DominikB2014
deleted the
dominikbuszowiecki/clarify-perf-general-settings-private-docstring
branch
October 23, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #127398, addressing this review comment.
The class docstring opened with "Kept private:", which wasn't clear on its own. It now says outright that the endpoint is kept private (excluded from the public API docs) and why. This only changes the docstring.
via @DominikB2014.
--
View Junior Session [Sentry]