Repository navigation
Conversation
This was referenced Oct 14, 2026
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQLfor --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQLfor --
-- Alter field checkin_config on monitorcheckin
--
SET CONSTRAINTS "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo" IMMEDIATE; ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo";
ALTER TABLE "sentry_monitorcheckin" ADD CONSTRAINT "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo" FOREIGN KEY ("checkin_config_id") REFERENCES "sentry_monitorcheckinconfig" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_monitorcheckin" VALIDATE CONSTRAINT "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo";
ALTER TABLE "sentry_monitorcheckin" ADD CONSTRAINT "sentry_monitorcheckin_checkin_config_id_17e2de71_notnull" CHECK ("checkin_config_id" IS NOT NULL) NOT VALID;
ALTER TABLE "sentry_monitorcheckin" VALIDATE CONSTRAINT "sentry_monitorcheckin_checkin_config_id_17e2de71_notnull";
ALTER TABLE "sentry_monitorcheckin" ALTER COLUMN "checkin_config_id" SET NOT NULL;
ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorcheckin_checkin_config_id_17e2de71_notnull"; |
wedamija
force-pushed
the
danf/crons-checkin-config-not-null
branch
from
October 14, 2026 22:01
d459312 to
7183bf7
Compare
wedamija
force-pushed
the
danf/crons-checkin-config-backfill
branch
from
October 15, 2026 20:25
f164d2f to
adddae9
Compare
wedamija
force-pushed
the
danf/crons-checkin-config-not-null
branch
from
October 15, 2026 21:57
7183bf7 to
93776fd
Compare
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge yet.
The serializer reads the config only from
checkin_config. By then, every check-in without acheckin_confighas aged out.Merge order:
monitor_config(30+ days after sentry#126539 deploys) ← this PRMOVE_TO_PENDING(after 2 deploys)DELETE(after 3 deploys)