Skip to content

ref(crons): Stop reading the check-in monitor_config column - #127449

Closed
wedamija wants to merge 1 commit into
masterfrom
danf/crons-checkin-config-not-null
Closed

wedamija wants to merge 1 commit into
masterfrom
danf/crons-checkin-config-not-null

Conversation

@wedamija

@wedamija wedamija commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Do not merge yet.

The serializer reads the config only from checkin_config. By then, every check-in without a checkin_config has aged out.

Merge order:

  1. sentry#126542: Backfill config references
  2. sentry#127449: Stop reading monitor_config (30+ days after sentry#126539 deploys) ← this PR
  3. sentry#127450: Remove the field from the model, MOVE_TO_PENDING (after 2 deploys)
  4. sentry#127451: Drop the column, DELETE (after 3 deploys)

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has a migration; here is the generated SQL for src/sentry/monitors/migrations/0017_backfill_checkin_config.py src/sentry/monitors/migrations/0018_fill_missing_checkin_config.py src/sentry/monitors/migrations/0019_make_checkin_config_not_null.py

for 0017_backfill_checkin_config in monitors

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

for 0018_fill_missing_checkin_config in monitors

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

for 0019_make_checkin_config_not_null in monitors

--
-- Alter field checkin_config on monitorcheckin
--
SET CONSTRAINTS "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo" IMMEDIATE; ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo";
ALTER TABLE "sentry_monitorcheckin" ADD CONSTRAINT "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo" FOREIGN KEY ("checkin_config_id") REFERENCES "sentry_monitorcheckinconfig" ("id") DEFERRABLE INITIALLY DEFERRED NOT VALID;
ALTER TABLE "sentry_monitorcheckin" VALIDATE CONSTRAINT "sentry_monitorchecki_checkin_config_id_17e2de71_fk_sentry_mo";
ALTER TABLE "sentry_monitorcheckin" ADD CONSTRAINT "sentry_monitorcheckin_checkin_config_id_17e2de71_notnull" CHECK ("checkin_config_id" IS NOT NULL) NOT VALID;
ALTER TABLE "sentry_monitorcheckin" VALIDATE CONSTRAINT "sentry_monitorcheckin_checkin_config_id_17e2de71_notnull";
ALTER TABLE "sentry_monitorcheckin" ALTER COLUMN "checkin_config_id" SET NOT NULL;
ALTER TABLE "sentry_monitorcheckin" DROP CONSTRAINT "sentry_monitorcheckin_checkin_config_id_17e2de71_notnull";

@wedamija
wedamija force-pushed the danf/crons-checkin-config-not-null branch from d459312 to 7183bf7 Compare October 14, 2026 22:01
@wedamija wedamija changed the title ref(crons): Require a check-in config and stop reading monitor_config ref(crons): Stop reading the check-in monitor_config column Oct 14, 2026
@wedamija
wedamija force-pushed the danf/crons-checkin-config-backfill branch from f164d2f to adddae9 Compare October 15, 2026 20:25
Base automatically changed from danf/crons-checkin-config-backfill to master October 15, 2026 21:41
@wedamija
wedamija force-pushed the danf/crons-checkin-config-not-null branch from 7183bf7 to 93776fd Compare October 15, 2026 21:57
@getsantry

getsantry Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Nov 6, 2026
@getsantry getsantry Bot closed this Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant