Repository navigation
feat: Send group status updates to snuba when archiving/unarchiving issues - #127454
Merged
Merged
Conversation
wedamija
reviewed
Oct 14, 2026
| """ | ||
| Copied and modified from `Queryset.update()` to support `RETURNING <returned_fields>` | ||
| """ | ||
| pk = self.model._meta.pk.name |
Member
There was a problem hiding this comment.
nit: Might make more sense to call this pk_name
| self._result_cache = None | ||
|
|
||
| if self._with_post_update_signal: | ||
| pk_index = returned_fields.index(pk) |
Member
There was a problem hiding this comment.
This is a little risky if fields happen to contain the same value. I think it might be better to just require that the first requested column is the pk
wedamija
approved these changes
Oct 14, 2026
RudraPatel2003
force-pushed
the
rudra-group-status-emitting
branch
from
October 14, 2026 23:39
f640d6e to
e57a69b
Compare
3 tasks done
2 tasks done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ID-1911
Context:
You can query errors on the "Explore > Errors" page and pass in issue status filters like "is:archived". Under the hood it relies on the group_attributes table in Clickhouse
Issue status is stored in postgres, and the way they are forwarded to Clickhouse is a post_save and post_update receiver that sends the new issue status to snuba
There is an option called "groups.enable-post-update-signal". This flag defaults to off but is on in most of the regions. If this flag is off, we rely on the django post_save signal. Otherwise, we call our custom post_update signal
This post_update signal is called only if the code calls the "update" function. If the code calls the "update_with_returning" function, we do not send the signal
A few months ago a change was made so that when updating a group, it uses the update_with_returning function instead of the update function. In prod, the post_save signal won't get sent because the option is enabled. The post_update signal doesn't get sent because it is not called in update_with_returning
Customer impact: If you archive an event on the UI, the events still show up as unarchived in the Explore page. And this breaks monitors where customers set the is:unresolved query because now metric monitors are counting events from archived issues