Skip to content

ref(profiling): Break circular dependency between flamegraphDrawer and profileDetails - #127475

Merged
ryan953 merged 2 commits into
masterfrom
seer/ref/profiling-flamegraph-drawer-cycle
Oct 15, 2026
Merged

ryan953 merged 2 commits into
masterfrom
seer/ref/profiling-flamegraph-drawer-cycle

Conversation

@sentry

@sentry sentry Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Fixes a circular dependency between flamegraphDrawer.tsx and profileDetails.tsx.

flamegraphDrawer.tsx imports ProfileDetails, while profileDetails.tsx previously imported ProfilingDetailsFrameTabs and ProfilingDetailsListItem from flamegraphDrawer.tsx.

Changes

  • Extracted ProfilingDetailsFrameTabs and ProfilingDetailsListItem into a dedicated styles.tsx module within flamegraphDrawer/
  • Converted ProfilingDetailsFrameTabs to use Flex from @sentry/scraps/layout to satisfy @sentry/scraps/prefer-primitives
  • Updated flamegraphDrawer.tsx and profileDetails.tsx to import the styled components from ./styles
  • Decremented the @sentry/scraps/prefer-primitives violation budget in oxlint-suppressions.json for flamegraphDrawer.tsx from 3 to 2

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Fixes CODING-CONVENTIONS-8YQ

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

@sentry
sentry Bot requested a review from a team as a code owner October 14, 2026 22:39
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 14, 2026

@ryan953 ryan953 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two styled components moved, one is a now to boot

@ryan953 ryan953 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Oct 15, 2026
@ryan953
ryan953 enabled auto-merge (squash) October 15, 2026 01:54
@ryan953
ryan953 merged commit 146b210 into master Oct 15, 2026
87 of 88 checks passed
@ryan953
ryan953 deleted the seer/ref/profiling-flamegraph-drawer-cycle branch October 15, 2026 01:54

This branch was successfully deployed

1 active deployment
Preview — 57ade7df Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant