Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/releases/endpoints/release_deploys.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def create_deploy(
organization_id=organization.id,
release=release,
environment_id=env.id,
date_finished=result.get("dateFinished", timezone.now()),
date_finished=result.get("dateFinished") or timezone.now(),
date_started=result.get("dateStarted"),
name=result.get("name"),
url=result.get("url"),
Expand Down
28 changes: 28 additions & 0 deletions tests/sentry/releases/endpoints/test_release_deploys.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,34 @@ def test_simple(self) -> None:
)
assert rpe.last_deploy_id == deploy.id

def test_null_date_finished_defaults_to_now(self) -> None:
release = self.create_release(project=self.project, version="1")

url = reverse(
"sentry-api-0-organization-release-deploys",
kwargs={
"organization_id_or_slug": self.org.slug,
"version": release.version,
},
)

before = datetime.datetime.now(datetime.UTC)
response = self.client.post(
url,
data={
"environment": "production",
"dateStarted": "2020-01-01T00:00:00Z",
"dateFinished": None,
},
format="json",
)
after = datetime.datetime.now(datetime.UTC)
assert response.status_code == 201, response.content

deploy = Deploy.objects.get(id=response.data["id"])
assert deploy.date_started == datetime.datetime(2020, 1, 1, tzinfo=datetime.UTC)
assert before <= deploy.date_finished <= after

def test_with_project_slugs(self) -> None:
project_bar = self.create_project(organization=self.org, name="bar")
release = Release.objects.create(organization_id=self.org.id, version="1", total_deploys=0)
Expand Down
Loading