Repository navigation
fix(authV2): allow account switching for signed-in org non-members - #131043
Open
akasakariko wants to merge 1 commit into
Open
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
Render organization login warnings as plain-text alerts without duplicating shared session-expired warnings, forward the requested next query parameter to /auth/config/, and offer a Sign in with a different account button for signed-in non-members outside single-organization mode when SSO is not required Fixes getsentry#127164
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127164
Signed-in non-members visiting an organization login page outside single-organization mode hit a dead end when the organization does not require SSO, because email/password authentication is hidden, the SSO button is disabled when no provider is configured, and organization warnings were not rendered
Changes:
authOrganization.warningsas plain-text warning alerts ahead ofloginConfig.warningandloginBannerMarkdown, deduplicating shared session-expired warningsSign in with a different accountbutton when a signed-in user is not member-authenticated on a non-demo organization without required SSO outside single-organization mode, callinglogoutto return to the current path and query string (orsloUrlwhen returned) with in-flight guarding and retryable error handlingnextquery parameter inuseAuthConfigso reloading/auth/login/<org>/?next=...after sign-out preserves the destination across authentication, and updateuseCancelSecondFactorAuthto match/auth/config/queries regardless of query paramsLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.