Repository navigation
ci(api): Check the packed package on Node.js 22 and Bun - #131208
Merged
Merged
Conversation
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
5 tasks
BYK
approved these changes
Nov 16, 2026
sentry-junior
Bot
force-pushed
the
ci/api-packed-consumers
branch
from
November 16, 2026 13:36
cd0c0c4 to
e9f7025
Compare
BYK
enabled stacked auto-merge (squash)
November 16, 2026 13:39
The api-client job now packs @sentry/api and installs the tarball into clean projects from the npm registry, on the oldest supported Node.js and on Bun. There it runs a typed operation against a mocked fetch, an HTTP error and a cancelled request with no optional peers, then each validator entry with only its own peer installed. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
ci/api-packed-consumers
branch
from
November 16, 2026 13:46
e9f7025 to
f4b258f
Compare
BYK
added a commit
that referenced
this pull request
Nov 16, 2026
…31210) Spec changes release `@sentry/api` as a minor version. So if a change removes an endpoint, or renames an `operationId` or a hand-written export, a minor release could silently break code written against the previous one. The `api client` job now compares the exports of each entry point in the packed tarball with the latest `@sentry/api` on npm. It fails when an entry point or export is gone. A rename shows up as the old name going missing. Adding exports is fine. Stacked on #131208, which adds the pack step this reuses. Part of #131204. **Open question for review:** there's no way yet to land an intended break. One option is a `Trigger: API Breaking Change` label that skips this step, together with a major bump in `api-package-release-preflight.sh`. Renaming the remaining sentence-style `operationId`s will hit this check. <!-- junior-request-attribution:start --> via @BYK. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent%3A69da19b385017e68b7f9eace56e9477f --> -- [View Session](https://junior-prod.sentry.dev/conversations/agent%3A69da19b385017e68b7f9eace56e9477f) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent%3A69da19b385017e68b7f9eace56e9477f/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: BYK <126780+BYK@users.noreply.github.com>
2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI step that installs the packed
@sentry/apitarball into a fresh project on Node.js 22, itsengines.nodefloor, and on Bun, as an outside project would. Each optional validator peer gets its own project. Before this, the package was only used on the repository's Node.js with workspace-linked dependencies.Part of #131204 and #131201.
via @BYK.
--
View Session [Sentry]