Skip to content

ci(api): Check the packed package on Node.js 22 and Bun - #131208

Merged
BYK merged 1 commit into
masterfrom
ci/api-packed-consumers
Nov 16, 2026
Merged

BYK merged 1 commit into
masterfrom
ci/api-packed-consumers

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Adds a CI step that installs the packed @sentry/api tarball into a fresh project on Node.js 22, its engines.node floor, and on Bun, as an outside project would. Each optional validator peer gets its own project. Before this, the package was only used on the repository's Node.js with workspace-linked dependencies.

Part of #131204 and #131201.

via @BYK.

--

View Session [Sentry]

@sentry-junior
sentry-junior Bot requested review from a team as code owners November 16, 2026 11:09
@sentry-junior
sentry-junior Bot requested a review from BYK November 16, 2026 11:10
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

The api-client job now packs @sentry/api and installs the tarball into clean projects from the npm registry, on the oldest supported Node.js and on Bun. There it runs a typed operation against a mocked fetch, an HTTP error and a cancelled request with no optional peers, then each validator entry with only its own peer installed.

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior
sentry-junior Bot force-pushed the ci/api-packed-consumers branch from e9f7025 to f4b258f Compare November 16, 2026 13:46
@BYK
BYK merged commit 7923a62 into master Nov 16, 2026
79 checks passed
@BYK
BYK deleted the ci/api-packed-consumers branch November 16, 2026 13:54
BYK added a commit that referenced this pull request Nov 16, 2026
…31210)

Spec changes release `@sentry/api` as a minor version. So if a change
removes an endpoint, or renames an `operationId` or a hand-written
export, a minor release could silently break code written against the
previous one.

The `api client` job now compares the exports of each entry point in the
packed tarball with the latest `@sentry/api` on npm. It fails when an
entry point or export is gone. A rename shows up as the old name going
missing. Adding exports is fine.

Stacked on #131208, which adds the pack step this reuses. Part of
#131204.

**Open question for review:** there's no way yet to land an intended
break. One option is a `Trigger: API Breaking Change` label that skips
this step, together with a major bump in
`api-package-release-preflight.sh`. Renaming the remaining
sentence-style `operationId`s will hit this check.

<!-- junior-request-attribution:start -->
via @BYK.
<!-- junior-request-attribution:end -->

<!-- junior-session-footer:start -->
<!-- junior-conversation-id:agent%3A69da19b385017e68b7f9eace56e9477f -->

--

[View
Session](https://junior-prod.sentry.dev/conversations/agent%3A69da19b385017e68b7f9eace56e9477f)
[[Sentry]](https://sentry.sentry.io/explore/conversations/agent%3A69da19b385017e68b7f9eace56e9477f/?project=4510944073809921)

<!-- junior-session-footer:end -->

Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: BYK <126780+BYK@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — f4b258f9 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant