Skip to content

fix: Silence missing symbol errors for .NET #45571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Swatinem merged 1 commit into from
Mar 9, 2023
Merged

fix: Silence missing symbol errors for .NET #45571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/sentry/lang/native/processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,17 @@ def _handle_image_status(status, image, sdk_info, data):
if not package or is_known_third_party(package, sdk_info=sdk_info):
return

# FIXME(swatinem): .NET never had debug images before, and it is possible
# to send fully symbolicated events from the SDK.
# Updating to an SDK that does send images would otherwise trigger these
# errors all the time if debug files were missing, even though the event
# was already fully symbolicated on the client.
# We are just completely filtering out these errors here. Ideally, we
# would rather do this selectively, only for images that were referenced
# from non-symbolicated frames.
if image.get("type") == "pe_dotnet":
return

if is_optional_package(package, sdk_info=sdk_info):
error = SymbolicationFailed(type=EventError.NATIVE_MISSING_OPTIONALLY_BUNDLED_DSYM)
else:
Expand Down