Repository navigation
feat: support PPDB embedded sources - #734
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 72.93% 73.24% +0.30%
==========================================
Files 69 69
Lines 14726 14914 +188
==========================================
+ Hits 10741 10924 +183
- Misses 3985 3990 +5 |
Swatinem
reviewed
Dec 14, 2022
Swatinem
left a comment
Swatinem
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just a small nit related to potential panics.
loewenheim
reviewed
Dec 14, 2022
Co-authored-by: Arpad Borsos <swatinem@swatinem.de> Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
Swatinem
approved these changes
Dec 15, 2022
Co-authored-by: Arpad Borsos <swatinem@swatinem.de>
Contributor
Author
|
Mind merging this? The new linter issue is not related to this PR, seem like the linter got updated? |
Contributor
yes, there was a Rust update yesterday. Well its a required CI check so I can’t merge without it :-D |
Contributor
Author
should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative 1 in #725
Next steps: is there anything else that needs to happen in symbolicator so that it works e2e?