Repository navigation
fix(cli): Explain server-side chunk upload failures - #2214
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Artifact bundle assembly errors now say the Sentry server failed to assemble the bundle, keep the server's detail, and note that Sentry caches the result for about 10 minutes (assemble status TTL), so a retry needs to wait or upload a changed bundle. A 5xx from the chunk-upload options request now names the server or proxy instead of printing its HTML error page. Its own error class keeps it from grouping with failed chunk POSTs, which share the ApiError status + command fingerprint rule. Assembly errors on self-hosted are silenced as `assembly_failed_self_hosted` and stay counted on `cli.error.silenced`. SaaS assembly errors are still captured. Co-Authored-By: bete <28983162+betegon@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…error-messages # Conflicts: # packages/cli/src/lib/api/chunk-upload.ts
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourcemap uploadfailures on 0.49.0 come from the server, not the CLI. There were 15 artifact bundle assembly errors (9Not all chunks available for assembling, 6internal server error), all on self-hosted instances. Another 12 are 5xx responses from the chunk-upload options GET, and those currently group under "Chunk upload failed". In both cases the CLI can't recover by retrying: Sentry caches the assemble result per bundle checksum for 10 minutes (set_assemble_status,ex=600), and the options GET already retries 5xx twice.This PR makes the errors say what happened:
AssemblyError. The message says the server failed to assemble the bundle, keeps the server's detail, and mentions the 10-minute cache.ChunkUploadOptionsError. The message points at the server or proxy instead of printing its HTML error page.Both are
ApiErrorsubclasses with their ownname, the same pattern asRateLimitError. The project's fingerprint rule groupsApiErrorby status and command, so the separate class name is what pulls them out of the 500 and 502 groups.Reporting rule: an
AssemblyErroron self-hosted (!isSaaS()) is silenced asassembly_failed_self_hosted, so it still counts oncli.error.silenced. On SaaS it is still captured, now under its own group. The options-GET error is still captured everywhere.Before
After
via @betegon.
--
View Session [Sentry]