Repository navigation
Conversation
max-krasnyansky
left a comment
Member
There was a problem hiding this comment.
This is an issue with quite old GCC and Clang.
You should probably just upgrade at this point
kou
reviewed
Dec 30, 2024
Contributor
There was a problem hiding this comment.
This is needless for recent GCC:
Suggested change
| if (CMAKE_CXX_COMPILER_ID MATCHES "GNU") | |
| if (CMAKE_CXX_COMPILER_ID MATCHES "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "9") |
FYI: We need c++fs (not stdc++fs) for Clang < 8 ((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "8")).
Member
|
This issue is going to keep popping up as we start using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add link library stdc++fs for ggml.