Repository navigation
Avoid hardcoding a space at the beginning of the prompt. - #1315
Closed
ivanstepanovftw wants to merge 1 commit into
Closed
ivanstepanovftw wants to merge 1 commit into
ivanstepanovftw wants to merge 1 commit into
Conversation
Contributor
|
I could be wrong about what's happening here, but I think with OpenLLaMA the BOS token is a lot more important: #1291 |
Contributor
Author
|
I am trying |
Member
|
The rationale is just duplicating what the SentencePiece tokenizer does. |
Collaborator
|
The rational was that the llama models where trained with a prefixed space. I agree that not every model has that requirement, but this was done to make it easier for users without this knowledge. |
Contributor
Author
|
Oh I see |
Contributor
Author
|
This is called dummy prefix google/sentencepiece#282 |
Member
|
You can put this functionality behind a cmd arg |
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
* Revive fused delta-net * Add command line argument for fused delta net * Simplify/improve CUDA delta-net * Add -fdn to llama-bench * More CUDA fused delta net optimizations * CPU optimizations * Much faster fused delta-net on the CPU It seems it is faster than the chunked implementation! * Change meaning of fdn from bool flag to threshold value * Use eps = 1e-6 * Give some nodes a name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in #242 without a strong rationale.
Users can already insert a space manually at the beginning of the prompt if desired.
For example, I cannot get rid of token 15629 ->
' Manager'. I am wanted it to be 3260 ->'Manager':