Skip to content

graph : fix stack-use-after-return - #14960

Merged
ggerganov merged 1 commit into
masterfrom
gg/graph-fix-stack-use-after-return
Jul 30, 2025
Merged

ggerganov merged 1 commit into
masterfrom
gg/graph-fix-stack-use-after-return

Conversation

@ggerganov

Copy link
Copy Markdown
Member

The graph reuse logic (#14482) was broken because the graph inputs could hold dangling references to llama_hparams and llama_cparams. This was spotted after enabling LLAMA_SET_ROWS=1 in the CI: #14959. The error is here: https://github.com/ggml-org/llama.cpp/actions/runs/16615559549/job/47007325550?pr=14959#step:7:21495

@ggerganov
ggerganov merged commit 1e15bfd into master Jul 30, 2025
@ggerganov
ggerganov deleted the gg/graph-fix-stack-use-after-return branch July 30, 2025 10:52
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Aug 1, 2025
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
MrLordCat referenced this pull request in MrLordCat/llama.cpp-rdna-lab Jul 16, 2026
zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant