Repository navigation
ui : model id grammar for sidecars, quants and capability parsing - #27946
Merged
ggerganov merged 2 commits intoSep 30, 2026
Merged
Conversation
allozaur
commented
Aug 29, 2026
allozaur
commented
Aug 29, 2026
allozaur
changed the title
allozaur
marked this pull request as ready for review
August 29, 2026 12:03
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds support in llama-ui for parsing and representing model “sidecar” types (draft/auxiliary GGUFs) from model IDs, and exposes a new tool-use capability in the UI.
Changes:
- Introduces sidecar enums/types and regexes, and extends
parseModelIdto detect sidecar prefixes/suffixes. - Adds
ModelsService.buildDownloadTag()to generate<repo>:<tag>for downloads. - Adds
ModelCapability.TOOL_USEwiring (icon/label/flag) and updates unit tests.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/ui/tests/unit/model-id-parser.test.ts | Extends expectations and adds coverage for sidecar parsing behaviors. |
| tools/ui/src/lib/types/models.d.ts | Adds tools capability flag and sidecar on parsed model IDs. |
| tools/ui/src/lib/services/models.service.ts | Implements sidecar parsing in parseModelId and adds buildDownloadTag(). |
| tools/ui/src/lib/enums/model.enums.ts | Adds sidecar enums and a new TOOL_USE capability. |
| tools/ui/src/lib/enums/index.ts | Re-exports new sidecar enums. |
| tools/ui/src/lib/constants/model-id.constants.ts | Defines sidecar tokens/types and regexes for prefix/suffix detection. |
| tools/ui/src/lib/constants/icons.constants.ts | Adds icon/label wiring for tool-use capability. |
| tools/ui/src/lib/components/app/models/ModelsSelectorOption.svelte | Surfaces tool-use capability in the model selector option UI state. |
| tools/ui/src/app.d.ts | Removes unused API request type imports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
August 30, 2026 06:36
209b7cd to
bc5c3b6
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
2 times, most recently
from
August 31, 2026 12:49
24f5bec to
f286815
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
August 31, 2026 15:41
f286815 to
da47401
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
2 times, most recently
from
August 31, 2026 22:50
1587726 to
f6f9046
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 4, 2026 18:07
f6f9046 to
ad8e42f
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 4, 2026 19:43
ad8e42f to
4a2aadd
Compare
allozaur
changed the title
This was referenced Sep 4, 2026
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 7, 2026 18:59
a693dd4 to
e1ce806
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 7, 2026 23:16
e1ce806 to
0809c49
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 16, 2026 11:11
0809c49 to
57842ce
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 16, 2026 11:14
57842ce to
0bdbf54
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 28, 2026 10:15
0bdbf54 to
774b215
Compare
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 28, 2026 14:34
774b215 to
21851a7
Compare
allozaur
removed this pull request from stack #28420
September 28, 2026 14:39
allozaur
added this pull request to stack #29589
September 28, 2026 14:47
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 28, 2026 14:48
21851a7 to
762e339
Compare
allozaur
removed this pull request from stack #29589
September 28, 2026 15:21
allozaur
added this pull request to stack #29592
September 28, 2026 15:22
allozaur
removed this pull request from stack #29592
September 29, 2026 10:42
allozaur
added this pull request to stack #29645
September 29, 2026 10:43
allozaur
force-pushed
the
allozaur/ui/model-id-parsing
branch
from
September 29, 2026 12:02
762e339 to
8a308f4
Compare
ServeurpersoCom
approved these changes
Sep 29, 2026
allozaur
added
the
merge ready
ggerganov
approved these changes
Sep 30, 2026
ServeurpersoCom
approved these changes
Sep 30, 2026
Extend the shared model id parser with sidecar tokens (draft variants and auxiliary imatrix/mmproj files), weight-file and custom-quant regexes, and add the tools capability to ModelCapabilities; the selector option row picks it up from the model's declared capabilities. Assisted-by: pi:GLM-5.3-Flash
Assisted-by: pi:zai-org/GLM-5.3-Flash
CISC
approved these changes
Sep 30, 2026
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Extends the shared model id parser (
MODEL_IDconstants) with sidecar tokens: speculative-decoding draft variants (mtp, dflash, dspark, eagle3) and auxiliary sidecars (mmproj, imatrix), including standalone-draftfiles. Adds thetoolscapability toModelCapabilitiesand covers the grammar with unit tests.Requirements
pi:zai-org/GLM-5.3+llama-ui:unsloth/Qwen3.8-Flash-Next