Repository navigation
Conversation
allozaur
left a comment
There was a problem hiding this comment.
@benbenbenbenbenben please run npm run format in tools/ui and update the failing Storybook test
|
Thanks for the fix. Could you also test it in router mode? The models selector already mounts the reasoning submenu there, so this needs to not end up showing it twice before it can be merged. Also you need to launch "npm run format" before commit. |
|
Very looking forward to this PR making it through. Reasoning menu was super useful. |
Additional Confirmation & Regression TimelineI have tested multiple builds and can provide a clear regression timeline for this issue:
Technical Details:
Workaround: Just a friendly reminder that this regression is still present in the latest master (B10930). Is there any ETA or blocker for PR #27985 to be merged? Thanks! |
|
@benbenbenbenbenben please update e2e tests that are failing on this PR |
The models selector already owns the reasoning submenu in router mode, so the add menu only mounts it in single model mode. The first enabled item of the add menu is now the reasoning submenu, the accessibility story expects it.
ServeurpersoCom
left a comment
There was a problem hiding this comment.
Besides the story test, I gated the add menu reasoning submenu on single model mode, since in router mode the models selector already mounts it and it showed up twice.
* ui: fix accidentally removed reasoning menu in single model mode on desktop * ui: formatting task run to fix storybook test * ui: mount the add menu reasoning submenu outside router mode only The models selector already owns the reasoning submenu in router mode, so the add menu only mounts it in single model mode. The first enabled item of the add menu is now the reasoning submenu, the accessibility story expects it. --------- Co-authored-by: Ben Babik <work@benjaminbabik.com> Co-authored-by: Pascal <admin@serveurperso.com>
…org#27985) * ui: fix accidentally removed reasoning menu in single model mode on desktop * ui: formatting task run to fix storybook test * ui: mount the add menu reasoning submenu outside router mode only The models selector already owns the reasoning submenu in router mode, so the add menu only mounts it in single model mode. The first enabled item of the add menu is now the reasoning submenu, the accessibility story expects it. --------- Co-authored-by: Ben Babik <work@benjaminbabik.com> Co-authored-by: Pascal <admin@serveurperso.com>
…org#27985) * ui: fix accidentally removed reasoning menu in single model mode on desktop * ui: formatting task run to fix storybook test * ui: mount the add menu reasoning submenu outside router mode only The models selector already owns the reasoning submenu in router mode, so the add menu only mounts it in single model mode. The first enabled item of the add menu is now the reasoning submenu, the accessibility story expects it. --------- Co-authored-by: Ben Babik <work@benjaminbabik.com> Co-authored-by: Pascal <admin@serveurperso.com>



Overview
This PR restores the missing reasoning menu in the web UI on large/desktop layouts when running in single model mode. The regression appears to have been introduced in #27744 and fixes #27981
Additional information
N/A
Requirements