Skip to content

ui: fix removed reasoning menu in single model mode on desktop - #27985

Merged
allozaur merged 3 commits into
ggml-org:masterfrom
benbenbenbenbenben:fix/restore-reasoning-submenu-desktop
Sep 17, 2026
Merged

allozaur merged 3 commits into
ggml-org:masterfrom
benbenbenbenbenben:fix/restore-reasoning-submenu-desktop

Conversation

@benbenbenbenbenben

@benbenbenbenbenben benbenbenbenbenben commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Overview

This PR restores the missing reasoning menu in the web UI on large/desktop layouts when running in single model mode. The regression appears to have been introduced in #27744 and fixes #27981

Additional information

N/A

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Qwen 3.8 27B was used to find the offending commit, I accepted a single line change suggestion and ran all git and gh operations manually.

@allozaur allozaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbenbenbenbenben please run npm run format in tools/ui and update the failing Storybook test

@ServeurpersoCom

Copy link
Copy Markdown
Contributor

Thanks for the fix. Could you also test it in router mode? The models selector already mounts the reasoning submenu there, so this needs to not end up showing it twice before it can be merged. Also you need to launch "npm run format" before commit.

@Remowylliams

Copy link
Copy Markdown

Very looking forward to this PR making it through. Reasoning menu was super useful.

@benbenbenbenbenben

Copy link
Copy Markdown
Contributor Author

Thanks for the fix. Could you also test it in router mode? The models selector already mounts the reasoning submenu there, so this needs to not end up showing it twice before it can be merged. Also you need to launch "npm run format" before commit.

I've tested it. In router mode on large screens the reasoning menu is in the correct location and I confirmed it doesn't duplicated when the screen is narrow.

Model selector on large screens:

image

Model selector on small screens:

image

Reasoning in "+" menu on small screens:

image

@DocTam

DocTam commented Sep 12, 2026

Copy link
Copy Markdown

Additional Confirmation & Regression Timeline

I have tested multiple builds and can provide a clear regression timeline for this issue:

  • Build B10621 (Last known good): Reasoning menu works perfectly on Desktop layout.
  • Build B10687 (First known bad): Reasoning menu disappears on Desktop layout.
  • Build B10809: Same behavior, menu is missing.
  • Build B10930 (Latest): Issue still persists.

Technical Details:

  • When the browser window width is >= 768px (Desktop layout), the Reasoning menu is missing.
  • When the browser window width is <= 767px (Mobile layout), the Reasoning menu reappears.
  • This perfectly matches the standard CSS md breakpoint (Tailwind). The regression introduced in PR ui: Improve Chat Form Actions UI/UX (models selector, add panel) #27746 is specifically tied to the desktop viewport rendering logic.

Workaround:
Resizing the browser window to <= 767px to trigger the mobile layout still works perfectly, which confirms the CSS breakpoint issue.

Just a friendly reminder that this regression is still present in the latest master (B10930). Is there any ETA or blocker for PR #27985 to be merged? Thanks!

@allozaur allozaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp fix before merging #28419

@allozaur

Copy link
Copy Markdown
Contributor

@benbenbenbenbenben please update e2e tests that are failing on this PR

The models selector already owns the reasoning submenu in router mode,
so the add menu only mounts it in single model mode. The first enabled
item of the add menu is now the reasoning submenu, the accessibility
story expects it.

@ServeurpersoCom ServeurpersoCom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the story test, I gated the add menu reasoning submenu on single model mode, since in router mode the models selector already mounts it and it showed up twice.

@allozaur
allozaur merged commit 4ff829e into ggml-org:master Sep 17, 2026
6 checks passed
CISC pushed a commit that referenced this pull request Sep 17, 2026
* ui: fix accidentally removed reasoning menu in single model mode on desktop

* ui: formatting task run to fix storybook test

* ui: mount the add menu reasoning submenu outside router mode only

The models selector already owns the reasoning submenu in router mode,
so the add menu only mounts it in single model mode. The first enabled
item of the add menu is now the reasoning submenu, the accessibility
story expects it.

---------

Co-authored-by: Ben Babik <work@benjaminbabik.com>
Co-authored-by: Pascal <admin@serveurperso.com>
LadislavSopko pushed a commit to 0ics-srls/llama.cpp that referenced this pull request Oct 5, 2026
…org#27985)

* ui: fix accidentally removed reasoning menu in single model mode on desktop

* ui: formatting task run to fix storybook test

* ui: mount the add menu reasoning submenu outside router mode only

The models selector already owns the reasoning submenu in router mode,
so the add menu only mounts it in single model mode. The first enabled
item of the add menu is now the reasoning submenu, the accessibility
story expects it.

---------

Co-authored-by: Ben Babik <work@benjaminbabik.com>
Co-authored-by: Pascal <admin@serveurperso.com>
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
…org#27985)

* ui: fix accidentally removed reasoning menu in single model mode on desktop

* ui: formatting task run to fix storybook test

* ui: mount the add menu reasoning submenu outside router mode only

The models selector already owns the reasoning submenu in router mode,
so the add menu only mounts it in single model mode. The first enabled
item of the add menu is now the reasoning submenu, the accessibility
story expects it.

---------

Co-authored-by: Ben Babik <work@benjaminbabik.com>
Co-authored-by: Pascal <admin@serveurperso.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

llama-ui : unable to open reasoning level selection menu on desktop

5 participants