Repository navigation
ui: add close button to UI toasts - #28246
Merged
Merged
Conversation
agustinmista
changed the title
allozaur
approved these changes
Sep 22, 2026
Contributor
|
I need to check something: 
|
Contributor
|
Trying a close/reopen to retrigger the CI, the pending runs reference a workflow file that was removed from master yesterday. |
Contributor
|
It worked, the CI is running again! |
agustinmista
force-pushed
the
toast-close-button
branch
from
September 22, 2026 07:18
cab11ce to
c7ed1f8
Compare
Contributor
|
Thanks for the rebase, it was not needed though, I would have merged it anyway since it was green, I just took advantage of the small change to check a GitHub CI corner case:) |
This commit tweaks the Toaster element to include a close button. These toasts often cover other UI elements like the model selector, and this change avoids having to wait for them to disappear on their own (e.g. after a load failure).
agustinmista
force-pushed
the
toast-close-button
branch
from
September 22, 2026 07:21
c7ed1f8 to
6453e57
Compare
ServeurpersoCom
approved these changes
Sep 22, 2026
Contributor
Author
|
Hey @ServeurpersoCom! Sorry, I was trying to fix the linting issue and I think I stepped on your toes 😅 |
Contributor
I saw it as entirely green on my end. But just as I was about to click, the rebase reset the CI:) |
This was referenced Sep 23, 2026
LadislavSopko
pushed a commit
to 0ics-srls/llama.cpp
that referenced
this pull request
Oct 5, 2026
This commit tweaks the Toaster element to include a close button. These toasts often cover other UI elements like the model selector, and this change avoids having to wait for them to disappear on their own (e.g. after a load failure).
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
This commit tweaks the Toaster element to include a close button. These toasts often cover other UI elements like the model selector, and this change avoids having to wait for them to disappear on their own (e.g. after a load failure).
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
This commit tweaks the Toaster element to include a close button. These toasts often cover other UI elements like the model selector, and this change avoids having to wait for them to disappear on their own (e.g. after a load failure). (cherry picked from commit 8cfc315)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR tweaks the
Toasterelement to include a close button.These toasts often cover other UI elements like the model selector, and this change avoids having to wait for them to disappear on their own (e.g. after a load failure).
Requirements