Repository navigation
vulkan: support mulmat bf16 activations - #29069
Merged
Merged
Conversation
github-actions
Bot
added
testing
0cc4m
force-pushed
the
0cc4m/vulkan-mulmat-bf16-activations
branch
from
September 30, 2026 12:33
1f65192 to
944962d
Compare
0cc4m
marked this pull request as ready for review
September 30, 2026 12:35
Contributor
Author
|
@jeffbolznv Can you review this when you have time? |
Contributor
|
I like how the conditions have been refactored, the logic is easier to follow. Hard to tell if it's equivalent, but I didn't find any bugs in it. I guess if bf16 activations become popular, we should handle them directly in the mul_mat_vec shader. But it's fine to skip that for now. codex found that the condition where we call ggml_vk_mul_mat_vec_nc_f16_f32 should check src1->type == GGML_TYPE_F32. |
Contributor
Author
|
Yes, the condition was missing, fixed. |
jeffbolznv
approved these changes
Oct 12, 2026
0cc4m
added
the
merge ready
CISC
approved these changes
Oct 13, 2026
Member
|
@0cc4m This seems to cause an error: https://github.com/ggml-org/llama.cpp/actions/runs/38517553292/job/115699649073#step:3:572 |
Contributor
Author
|
Oof, I guess there was a non-obvious merge conflict. I'll fix it. |
Contributor
Author
|
Fixed in #30495 |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Support bf16 mul_mat activations as added in #28937. Draft until that PR is done.
I also used the chance to clean up the b-type selection code that had grown a lot over time and was getting convoluted.
Requirements