Repository navigation
chat : fix gemma4 required tool grammar - #29115
Conversation
|
He's right, though. An interaction of two
|
pwilkin
left a comment
There was a problem hiding this comment.
For required tool calls this is the right workaround, but we should think about a way to fix the "double until" behavior.
|
Well, that's why we remove them! It's only a problem in a CFG grammar. The PEG parser, being greedy, doesn't have the same issue. For grammars, |
This problem will mostly go away once we add token-aware parsing and we can construct grammars that operate on tokens. |
Overview
Fixes #29089. The parsing for awkward edge cases negatively impacts the grammar when
tool_choice = required.Requirements