Repository navigation
chat : Fix Muse Glimmer tool-call first parser error - #29242
Merged
Merged
Conversation
|
Hi @NickM-27, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
Contributor
Author
|
Happy to mark this as a draft if desired, but to be clear I do already have a PR merged that has been merged. |
Contributor
|
You can condense this to one rule: - "^( to=(?!self<\\|message\\|>)(?!user<\\|message\\|>)[^<]*?<\\|message\\|>)" },
- { COMMON_GRAMMAR_TRIGGER_TYPE_PATTERN,
- "<\\|start\\|>assistant( to=(?!self<\\|message\\|>)(?!user<\\|message\\|>)[^<]*?<\\|message\\|>)" },
+ "(?:^|<\\|start\\|>assistant)( to=(?!self<\\|message\\|>)(?!user<\\|message\\|>)[^<]*?<\\|message\\|>)" }, |
aldehir
reviewed
Sep 21, 2026
pwilkin
approved these changes
Sep 22, 2026
This was referenced Sep 23, 2026
LadislavSopko
pushed a commit
to 0ics-srls/llama.cpp
that referenced
this pull request
Oct 5, 2026
* Fix Muse Glimmer tool-call first parser error * Add test to verify * Condense patterns * remove test for trigger patterns
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
* Fix Muse Glimmer tool-call first parser error * Add test to verify * Condense patterns * remove test for trigger patterns
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
* Fix Muse Glimmer tool-call first parser error * Add test to verify * Condense patterns * remove test for trigger patterns (cherry picked from commit 7ab4ee7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an error with Muse Glimmer when the turn started immediately as a tool call with no reasoning step.
Additional information
fixes #29240
This is similar to an behavior that GPT-OSS has and is handled by the parser
Requirements