Repository navigation
Conversation
The models/ split dropped the loop-head capture (present at 38a5b42, src/models/lfm2.cpp:252), so any decode with embeddings_layer_inp set - i.e. serving an LFM2 target with a DFlash/DSpark drafter - aborts in llm_graph_result::set_outputs (llama-graph.cpp:1352 'layer input tensor is null') as soon as graph_reserve builds the embd-batch graph variant, e.g. on the first mtmd image chunk of a vision request. Same unconditional capture style as qwen3.cpp. Verified: LFM2.5-VL-3B + DSpark sidecar no longer crashes on image requests; text-only LFM2.5-2.6B + its released sidecar unaffected (tau ~3.8 on a math probe).
|
Hi @tugot17, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
|
cc @tdakhran if you have have a look |
There was a problem hiding this comment.
This line was already added in https://github.com/ggml-org/llama.cpp/pull/27383/changes#diff-a594bdf207682148894799362abd56072082a07d86986283752f47172ae9babaR252-R253 , why did it disappear?
tdakhran
left a comment
There was a problem hiding this comment.
The PR is based on the commit before DSpark support for LFM2 was merged https://github.com/ggml-org/llama.cpp/pull/27383/changes#diff-a594bdf207682148894799362abd56072082a07d86986283752f47172ae9babaR252-R253
please cancel.
This makes LFM2.5-VL-3B work with a DSpark draft model.
The lfm2 graph lost its
t_layer_inpcapture in the models/ split (still there at 38a5b42, and qwen3.cpp kept its copy). Without it the server asserts on the first request whenever a drafter is attached:One line to put it back.
Testing:
Target and mmproj are public, the draft sidecar is gated on my HF, ping me for access.
Accept length on a 20-sample MMSpec probe: 3.86 (at 38a5b42), our internal fork gets ~4.1 on the same samples. Greedy output is identical with and without the drafter.
Things I hit on the way that this PR does not fix: