Repository navigation
Conversation
ggml-org#29276 rejects feature_layer indices above n_layer. Also reject negative indices: conversions are expected to standardize on non-negative values (-1 is used internally to mark values as unset), so a negative declared index is malformed and should fail loudly instead of being silently ignored. Also include the offending key and the valid range in the error message to make malformed projectors easier to identify.
|
Hi @3em0, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29276, which added a range check for
clip.*.feature_layer(indices aboven_layerare rejected). Two small hardenings:No behavior change for well-formed files.
Testing
feature_layer = [4096]withblock_count = 2: fails to load with the range error, same as masterfeature_layervalue: now fails to load with the range error (previously the value was silently ignored and the default layer choice was used)[0, n_layer](llava, minicpmv-family, granite-vision): load as before