Skip to content

musa: build the docker images from the PH1 MUSA SDK image - #29481

Merged
CISC merged 1 commit into
ggml-org:masterfrom
yeahdongcn:xd/musa-docker-sdk-bump
Sep 26, 2026
Merged

CISC merged 1 commit into
ggml-org:masterfrom
yeahdongcn:xd/musa-docker-sdk-bump

Conversation

@yeahdongcn

@yeahdongcn yeahdongcn commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

Fix https://github.com/ggml-org/llama.cpp/actions/runs/36217768484/job/108352515572#step:10:2607

Testing Done

Additional information

Requirements

@CISC CISC left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the Publish Docker image job on your fork.

Comment thread .devops/musa.Dockerfile
ARG BASE_MUSA_DEV_CONTAINER=registry.mthreads.com/mcconline/inference/pytorch:2.9.1.post1-py3.10-musa5.2.0-mp31-devel-ubuntu${UBUNTU_VERSION}-amd64

ARG BASE_MUSA_RUN_CONTAINER=docker.io/mthreads/musa:${MUSA_VERSION}-runtime-ubuntu${UBUNTU_VERSION}-amd64
ARG BASE_MUSA_RUN_CONTAINER=${BASE_MUSA_DEV_CONTAINER}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No separate runtime image?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right. For now, we only have the PyTorch-based dev image. I'm happy to open an internal ticket to publish a corresponding new dev/runtime Docker image, and I'll send out a new PR to address this.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the Ubuntu 24.04 variant as well.

@CISC

CISC commented Sep 26, 2026

Copy link
Copy Markdown
Member

TODO (building in progress)

Please note that we build for Ubuntu 24.04 in our daily workflow.

@github-actions github-actions Bot added documentation Improvements or additions to documentation devops improvements to build systems and github actions labels Sep 26, 2026
@CISC

CISC commented Sep 26, 2026

Copy link
Copy Markdown
Member

TODO (building in progress)

Please note that we build for Ubuntu 24.04 in our daily workflow.

Sorry, that wasn't quite accurate, we build on 24.04, but the image is built for 22.04.

@CISC
CISC merged commit 694ec23 into ggml-org:master Sep 26, 2026
3 checks passed
edwardyoon pushed a commit to edwardyoon/focus-llama that referenced this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants