Repository navigation
convert : export YaRN scaling parameters for PLaMo-3 - #29528
Merged
Merged
Conversation
Recent PLaMo-3 models use YaRN, while some earlier PLaMo-3 models do not. The recent PLaMo-3 store their YaRN settings as flat config keys (rope_scaling_factor, initial_context_length) and build the dict at runtime in Plamo3Config.rope_parameters. The current converter misses these settings and writes plain RoPE metadata to GGUF. Mirror the runtime settings into rope_parameters so the corresponding rope.scaling.* is written to GGUF.
CISC
approved these changes
Sep 27, 2026
CISC
left a comment
CISC
left a comment
Member
There was a problem hiding this comment.
Not sure why they would do it like this, but nice fix.
CISC
added
the
merge ready
pierreguillot
pushed a commit
to Ircam-Partiels/llama.cpp
that referenced
this pull request
Oct 1, 2026
Recent PLaMo-3 models use YaRN, while some earlier PLaMo-3 models do not. The recent PLaMo-3 store their YaRN settings as flat config keys (rope_scaling_factor, initial_context_length) and build the dict at runtime in Plamo3Config.rope_parameters. The current converter misses these settings and writes plain RoPE metadata to GGUF. Mirror the runtime settings into rope_parameters so the corresponding rope.scaling.* is written to GGUF.
frostyautumnleaf
pushed a commit
to frostyautumnleaf/llama.cpp
that referenced
this pull request
Oct 5, 2026
Recent PLaMo-3 models use YaRN, while some earlier PLaMo-3 models do not. The recent PLaMo-3 store their YaRN settings as flat config keys (rope_scaling_factor, initial_context_length) and build the dict at runtime in Plamo3Config.rope_parameters. The current converter misses these settings and writes plain RoPE metadata to GGUF. Mirror the runtime settings into rope_parameters so the corresponding rope.scaling.* is written to GGUF.
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 7, 2026
Recent PLaMo-3 models use YaRN, while some earlier PLaMo-3 models do not. The recent PLaMo-3 store their YaRN settings as flat config keys (rope_scaling_factor, initial_context_length) and build the dict at runtime in Plamo3Config.rope_parameters. The current converter misses these settings and writes plain RoPE metadata to GGUF. Mirror the runtime settings into rope_parameters so the corresponding rope.scaling.* is written to GGUF. (cherry picked from commit 9adc7f4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
fixes: #29519
Mirror the runtime settings into rope_parameters so the corresponding rope.scaling.* is written to GGUF.
Requirements