Skip to content

common, server : add model type to GET /models - #29944

Closed
angt wants to merge 1 commit into
ggml-org:masterfrom
angt:server-add-model-type-to-get-models
Closed

angt wants to merge 1 commit into
ggml-org:masterfrom
angt:server-add-model-type-to-get-models

Conversation

@angt

@angt angt commented Oct 4, 2026

Copy link
Copy Markdown
Member

Overview

Add a type field to GET /v1/models and GET /models.

The field gives the kind of the model:

  • classifier: a native decision model. Use /v1/systemone for it.
  • model: a normal model. Its metadata has no decision type.
  • unknown: the metadata is missing or not valid.

Additional information

earendil-works/pi#10382

Requirements

@angt
angt requested review from a team as code owners October 4, 2026 12:30
@github-actions github-actions Bot added documentation Improvements or additions to documentation server labels Oct 4, 2026
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
@angt
angt force-pushed the server-add-model-type-to-get-models branch from 9cfc222 to 3253f96 Compare October 4, 2026 17:04

@ngxson ngxson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX-wise, I think having a single type is not very future-proof

In the past, we had the same story with models capable of doing infill/embeddings/reranking and combination of them. The verdict was to have an array of tags to indicate model's capability.

Maybe we can do the same here? Models capable of both clasification+chat are totally possible and high chance we will see some popping up soon

@ggerganov

Copy link
Copy Markdown
Member

Does it make sense this to be input or output modality, similar to text, vision, audio etc?

@angt

angt commented Oct 5, 2026 •

Copy link
Copy Markdown
Member Author

Something like that ?

{
  "architecture": {
    "input_modalities": ["text"],
    "output_modalities": ["decisions"]
  }
}

see openrouter: https://openrouter.ai/docs/guides/overview/models

@ggerganov

Copy link
Copy Markdown
Member

This makes sense to me, but would defer to @ngxson for the final say.

@pcuenca

pcuenca commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

openrouter skips decision models in the list unless explicitly asked for, not sure if we want to to do the same.

There's also a proposal to add capabilities to the OpenAI API, but no idea if it's getting accepted.

@ggerganov

Copy link
Copy Markdown
Member

Given that OpenRouter does it like this, I think it's one more reason to follow that - better than adding our alternative at this point?

@mitsuhiko Would it work for you if the decision type is announced in the output modalities?

openrouter skips decision models in the list unless explicitly asked for, not sure if we want to to do the same.

Hm, don't see what is the reason to do that. Returning everything by default should be OK.

@pcuenca

pcuenca commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Yes, both make sense to me (use the output modalities, return everything).

@ngxson

ngxson commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

yeah I think the output_modalities would be the best

@angt

angt commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

Superseded by #29987

@angt angt closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants