[ckastner]

Overview

See discussion in #29997. This prevents a handful of internal symbols leaking via GGML_API.

Additional information

Using scripts/check-apiabi-compat.sh to compare build results before and after this change, this causes hiding of the following symbols:

7 Removed function symbols not referenced by debug info:
 
  [D] ggml_graph_next_uid
  [D] ggml_graph_view
  [D] ggml_hash_set_free
  [D] ggml_hash_set_new
  [D] ggml_hash_set_reset
  [D] ggml_hash_size
  [D] ggml_print_backtrace
 
1 Removed variable symbol not referenced by debug info:
 
  [D] ggml_critical_section_mutex

None of these are in ggml/include so I hiding them seems to be the right thing to do.

I also tried changing the visibility for llama.cpp, but the build then failed, so the default visibility does matter there. I'm not sure it's worth the effort to dig down, instead of waiting for an actual problem first.

@ggerganov WDYT?

Requirements

• I have read and agree with the contributing guidelines
• AI usage disclosure: No

[ggerganov]

Yes, libllama is not ready for default hidden. But ggml should be good I think.

[ckastner]

@ggerganov pinging, just to ensure that this doesn't affect the next release.

I think the test errors are unrelated. But I could rebase and trigger a new test?

[ggerganov]

Thanks for the ping.