[ngxson]

Overview

Some refactor planned from #29987

Note that common_get_decision_type current can take the gguf path and manually open it to grab the metadata. If we have similar logic in the same future, it will be important to have one gguf_context that can be reused by multiple calls

Requirements

• I have read and agree with the contributing guidelines
• AI usage disclosure: yes

[ServeurpersoCom]

LGTM, dropping the child report entirely is cleaner than validating it, and the video limitation is documented.

[angt]

Maybe I missed something, but child report was required to update the modality and help pi discover the model without restarting the router or reloading the model. Video support was a free bonus with that.

[ngxson]

@angt my intention was to not parse child-reported /models data because whatever already in router's meta.architecture.to_json() must match child's "architecture" field

note sure if you found any cases where this may break?

for example:

• router detects child to have output: text, decision
• then, when child is launch, its "architecture" output modalities should also report: text, decision

in other words, I want to design it such that both router and child produce the same "architecture", even though they may take 2 different code paths. this way, there is no need to sync them

[angt]

@ngxson the case I was thinking of is a preset to a model that isn't downloaded yet so the router fallback to text and they will differ

[ngxson]

hmm, make sense. in this case, we should have an event called model_mutated that get fired whenever child mutate the model file, so that router should update

pushing a new commit now

[ServeurpersoCom]

It seems dropping the default initializer of architecture in server_model_meta turns CI red (-Werror=missing-field-initializers on GCC arm64), it should be put back with = {}.

[angt]

If 2 presets use the same GGUF, the first one download the file and notify the router, but not the second one? 🤔

[angt]

Maybe we can just force a refresh when a child is ready ?