Repository navigation
hexagon: correct HMX FA sinks - #30581
Merged
Merged
Conversation
Member
|
Nice. I've been meaning to revisit those accuracy mismatches with sinks. The HVX FA is passing all tests cleanly (you can force it with GGML_HEXAGON_FA_SELECT=1) but the HMX always had a slight mismatch ever since I added the sinks (specifically for better GPT-OSS-20B support). Will check it out on my setups asap. |
max-krasnyansky
force-pushed
the
wt/hexagon-hmx-fa-sinks
branch
from
October 16, 2026 05:24
f27115c to
7cb3a89
Compare
max-krasnyansky
approved these changes
Oct 16, 2026
Member
|
Vectorized sinks logic and removed register spills. |
lhez
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Related to my finding in #30218,
test-backend-ops -o FLASH_ATTN_EXTwas 2541/2604 (63 failed on sinks=1) on single NPU, 2549/2604 on row split.In this PR:
l += 2^(sink * log2e - m), move tofa_build_d_diag_inv_lAdditional information
test-backend-ops -o FLASH_ATTN_EXT (IQ-9075)
HTP0:0), passedsinks=1HTP0[0-1]), passedsinks=1No performance regression found. Also tested on gpt-oss 20b mxfp4 (IQ-9075 with NPU, 8-session layer split), prefill KLD vs CPU 0.0410 -> 0.0293.
Requirements