Repository navigation
refactor : move LFM2 shortconv and FFN blocks into a shared LFM base - #30874
Merged
Merged
Conversation
github-actions
Bot
added
model
ngxson
marked this pull request as ready for review
October 20, 2026 15:17
tdakhran
force-pushed
the
tarek/refactor/02-lfm-base
branch
from
October 20, 2026 16:11
0eb44ec to
44c6aad
Compare
Contributor
Author
|
rebased, ready for review! |
ggerganov
approved these changes
Oct 20, 2026
Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
CISC
approved these changes
Oct 20, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 24, 2026
…gml-org#30874) * llama : move LFM2 shortconv and FFN blocks into a shared LFM base * Update src/models/lfm-base.cpp Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This was referenced Oct 27, 2026
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
…gml-org#30874) * llama : move LFM2 shortconv and FFN blocks into a shared LFM base * Update src/models/lfm-base.cpp Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Move LFM2 shortconv and FFN blocks into a shared LFM base for future reuse.
Additional information
Will be reused by future models.
llama-perplexity(-c 512 --chunks 8) before/after, identical per-chunk values:Requirements