Repository navigation
server : fix /v1/responses endpoint to accept extra_params - #30959
Merged
Merged
Conversation
Dgarc359
force-pushed
the
fix/v1-responses-extra-params
branch
from
October 22, 2026 03:15
99d9d01 to
ad5f73a
Compare
Contributor
Author
|
@ServeurpersoCom visibility bump, is this on the radar? Thanks |
ServeurpersoCom
approved these changes
Oct 25, 2026
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
Same pattern as #30856: both /v1/responses and /v1/responses/input_tokens go through the converter, so extra_params lands in the same params parse as /v1/chat/completions. LGTM
ngxson
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
/v1/responsesendpoint now honorsextra_params, which allows such keys asseedandmin_pto be passed forward to the serverDocumentation has been adjusted to include details regarding the new field. Tests were excluded this time around to follow the conventions of the last PR, but I can make those changes if required. Thanks.
Additional information
This is a follow up to #30856
Requirements