Skip to content

server : fix /v1/responses endpoint to accept extra_params - #30959

Merged
ngxson merged 1 commit into
ggml-org:masterfrom
Dgarc359:fix/v1-responses-extra-params
Oct 31, 2026
Merged

ngxson merged 1 commit into
ggml-org:masterfrom
Dgarc359:fix/v1-responses-extra-params

Conversation

@Dgarc359

Copy link
Copy Markdown
Contributor

Overview

/v1/responses endpoint now honors extra_params, which allows such keys as seed and min_p to be passed forward to the server

Documentation has been adjusted to include details regarding the new field. Tests were excluded this time around to follow the conventions of the last PR, but I can make those changes if required. Thanks.

Additional information

This is a follow up to #30856

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes for debugging and testing my new changes

@Dgarc359
Dgarc359 requested a review from a team as a code owner October 22, 2026 02:58
@github-actions github-actions Bot added documentation Improvements or additions to documentation server labels Oct 22, 2026
@Dgarc359
Dgarc359 force-pushed the fix/v1-responses-extra-params branch from 99d9d01 to ad5f73a Compare October 22, 2026 03:15
@Dgarc359

Copy link
Copy Markdown
Contributor Author

@ServeurpersoCom visibility bump, is this on the radar? Thanks

@ServeurpersoCom ServeurpersoCom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same pattern as #30856: both /v1/responses and /v1/responses/input_tokens go through the converter, so extra_params lands in the same params parse as /v1/chat/completions. LGTM

@ngxson
ngxson merged commit 2871678 into ggml-org:master Oct 31, 2026
12 of 13 checks passed
edwardyoon pushed a commit to edwardyoon/focus-llama that referenced this pull request Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants