Repository navigation
vocab : use Tekken pre-tokenizer for pixtral rather than the Llama 3 one - #30960
Merged
Merged
Conversation
danbev
approved these changes
Oct 22, 2026
CISC
approved these changes
Oct 22, 2026
3 of 6 tasks
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 24, 2026
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Tekken pre-tokenizer is now used by
pixtralrather than Llama 3's. The reason for this is because thepixtralhash was from the community Pixtral copy, and that utilized the regex of Llama 3. The Tekken regex is used by the officialtekken.jsonfrom Mistral, Nemotron 3 and 3.5, and Ministral-3, which is why those GGUFs were splitting text incorrectly (as an example, Hindiदीwas 2 tokens rather than 1).Fixes #30894
Additional information
Hugging Face PR link: https://huggingface.co/ggml-org/vocabs/discussions/3
The Nemotron test fails on master on Thai/Hindi and passes with the fix. All 15
test-tokenizer-0tests now pass. This affects the line next to the one changed by #30940, so one of the two might need a rebase.Requirements