Repository navigation
CUDA: fix build after chunked CUDA graphs (#30804) - #31053
Merged
ServeurpersoCom merged 3 commits intoOct 23, 2026
Merged
ServeurpersoCom merged 3 commits into
ServeurpersoCom merged 3 commits into
Conversation
Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
JohannesGaessler
approved these changes
Oct 23, 2026
Member
|
Please fix newlines in |
ServeurpersoCom
approved these changes
Oct 23, 2026
Contributor
|
Quick merge to unbreak the build. The rocm failure is a runner issue, not this change: the HIP build step stops at 47% with no compile error, then test-llama-archs is missing. The hip job, which compiles ggml-cuda.cu, is green. |
Contributor
|
Built it here on Linux (CUDA) and on Windows (MSVC): both compile and run again with this change, so the build is fixed. |
3 of 6 tasks
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 24, 2026
…31053) * CUDA: fix build after chunked CUDA graphs (ggml-org#30804) * Apply suggestion from @JohannesGaessler Co-authored-by: Johannes Gäßler <johannesg@5d6.de> * Fix newlines in common.cuh --------- Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
…31053) * CUDA: fix build after chunked CUDA graphs (ggml-org#30804) * Apply suggestion from @JohannesGaessler Co-authored-by: Johannes Gäßler <johannesg@5d6.de> * Fix newlines in common.cuh --------- Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the CUDA/HIP/MUSA build on master.
#30804 replaced
ggml_cuda_graph::instancewithinstances, butinvalidate_cuda_graphs()from #26771 still usesgraph->instance, which breaks the CUDA/HIP build.Fixed with
graph->instances.size().Additional information
Failing CI on 280141e (before):
The CI on this PR is the regression test. Expecting it to pass.
Requirements
instancereference and check that no other uses of the removed fields remain. I reviewed and understand the change.