Skip to content

jinja : cap from_json nesting depth (fixes #30834) #31099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samgsx wants to merge 2 commits into from
Closed

jinja : cap from_json nesting depth (fixes #30834) #31099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c12763
jinja : cap from_json nesting depth (fixes #30834)
Oct 24, 2026
7256b81
Merge branch 'master' into fix/jinja-from-json-depth
samgsx Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions common/jinja/value.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,6 +1440,14 @@ const func_builtins & value_undefined_t::get_builtins() const {
//////////////////////////////////


// request-derived JSON is untrusted; cap conversion depth so deeply nested
// payloads throw instead of overflowing the stack
static constexpr size_t k_from_json_max_depth = 128;

static value from_json(const common_json & j, bool mark_input, size_t depth = 0) {
if (depth > k_from_json_max_depth) {
throw std::runtime_error("JSON nesting depth exceeds " + std::to_string(k_from_json_max_depth));
}
// the runtime walks values with recursion, a deeper input overflows the stack
static constexpr int FROM_JSON_MAX_DEPTH = 128;

Expand Down