Skip to content

ui: align alert dialog styling with other overlay surfaces - #31312

Merged
ggerganov merged 1 commit into
masterfrom
allozaur/style/alert-dialog-consistency
Nov 2, 2026
Merged

ggerganov merged 1 commit into
masterfrom
allozaur/style/alert-dialog-consistency

Conversation

@allozaur

@allozaur allozaur commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Alert dialogs (delete conversation, delete message, reset settings, etc.) now share the surface of the other overlays: popover background, the softer dark:border-border/20 border, rounded-xl corners and shadow-md, matching dropdowns, hover cards and the settings dialog. Previously they used the page background with a full-opacity border and rounded-lg, which made them look heavier and darker than everything around them, especially in dark mode. The title also gets leading-none like the regular dialog title.

Demo script
test.describe('pr-31312', () => {
	test.use({
		settings: { alwaysShowSidebarOnDesktop: true },
		traces: ['long-chat']
	});

	test('demo', async ({ demo, page }) => {
		const sidebar = page.locator('aside');
		const chat = sidebar.getByText('Building a weather CLI in Rust');
		const row = sidebar.locator('li', { hasText: 'Building a weather CLI in Rust' });

		await expect(chat).toBeVisible({ timeout: 30_000 });
		await demo.hover(chat, 600);
		// the row's own button and the actions trigger both carry the label; the trigger is the last one
		await demo.click(row.locator('button:has(.sr-only:text-is("More actions"))').last(), 700);
		await demo.click(page.getByRole('menuitem', { name: 'Delete' }), 700);

		const dialog = page.getByRole('alertdialog');
		await expect(dialog).toBeVisible();
		await demo.caption('Deleting a conversation asks for confirmation first', 2600);

		await demo.click(dialog.getByRole('button', { name: 'Cancel' }), 800);
		await expect(dialog).toBeHidden();
		await demo.caption('Cancel keeps the conversation', 1600);
	});
});

Demo

Demo

Recorded at eed6795; click the preview for the full video.

Requirements

Use the popover background, softer border, rounded-xl corners and
shadow-md like dropdowns, hover cards and the settings dialog, and
match the dialog title line height.

Assisted-by: Claude (Opus 5.5 Medium)
@allozaur allozaur added the video demo PR features a video demo recorded with the UI demo pipeline label Oct 29, 2026
@allozaur
allozaur marked this pull request as ready for review October 29, 2026 12:01
@allozaur
allozaur requested a review from a team as a code owner October 29, 2026 12:01
Copilot AI balanced review requested due to automatic review settings October 29, 2026 12:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@allozaur allozaur added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Oct 29, 2026
@ggerganov
ggerganov merged commit 23426d7 into master Nov 2, 2026
8 checks passed
edwardyoon pushed a commit to edwardyoon/focus-llama that referenced this pull request Nov 6, 2026
…31312)

Use the popover background, softer border, rounded-xl corners and
shadow-md like dropdowns, hover cards and the settings dialog, and
match the dialog title line height.

Assisted-by: Claude (Opus 5.5 Medium)
(cherry picked from commit 23426d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. server/ui video demo PR features a video demo recorded with the UI demo pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants