Repository navigation
ui: show interrupted state for tool calls that never returned - #31314
Merged
Merged
Conversation
The chat-level streaming flag was applied to every assistant message, so a tool call left without a result in an earlier message kept spinning while a newer reply streamed. Scope streaming to the last assistant message and mark finished calls without a result as interrupted. Assisted-by: Claude (Opus 5.5 Medium)
exec_shell_command creates its result message before running, so stopping it mid-run leaves an empty result instead of none. Assisted-by: Claude (Opus 5.5 Medium)
allozaur
marked this pull request as ready for review
October 29, 2026 12:05
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
ServeurpersoCom
approved these changes
Oct 29, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Nov 6, 2026
…rg#31314) * ui: show interrupted state for tool calls that never returned The chat-level streaming flag was applied to every assistant message, so a tool call left without a result in an earlier message kept spinning while a newer reply streamed. Scope streaming to the last assistant message and mark finished calls without a result as interrupted. Assisted-by: Claude (Opus 5.5 Medium) * ui: mark a shell command stopped before any output as interrupted exec_shell_command creates its result message before running, so stopping it mid-run leaves an empty result instead of none. Assisted-by: Claude (Opus 5.5 Medium) (cherry picked from commit 64be95b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A tool call that was stopped before it returned now shows as interrupted, instead of spinning on "Executing command..." for good.
Demo
Recorded at 39d6e3f; click the preview for the full video.
Additional information
Calls skipped by a steering message are unchanged: they already get a "Tool execution was interrupted by a new user message." result, shown as plain output.
Cause
The chat-level
isStreamingflag was passed to every assistant message, so an older message treated its unresolved call as still pending while a newer reply streamed. Separately,exec_shell_commandcreates its result message before running, so stopping it mid-run left an empty result that rendered as a bare title with no status.What changed
ChatMessageAgenticContentonly treats the last assistant message as streaming.ToolCallBlockmarks a finished call without a result asinterrupted, shown next to the existingfailed/incompletelabels.exec_shell_commandopts in to treating an empty result the same way.exec_shell_commandblock shows a stop icon with "Command interrupted before it returned output" instead of the spinner.Testing
tests/client/exec-shell-command-streaming.svelte.test.tscovers a call left without a result after streaming stops, a command stopped before any output, and an earlier message while a newer reply streams.isLastAssistantMessage: true.sleep 40command stopped mid-run shows theinterruptedlabel.Demo script
Requirements
Claude (Opus 5.5 Medium)