Skip to content

Improvements for running on Windows with Snapdragon X - #8531

Merged
ggerganov merged 11 commits into
ggml-org:masterfrom
AndreasKunar:snapdragonxwin-fix1
Jul 25, 2024
Merged

ggerganov merged 11 commits into
ggml-org:masterfrom
AndreasKunar:snapdragonxwin-fix1

Conversation

@AndreasKunar

@AndreasKunar AndreasKunar commented Jul 17, 2024 •

Copy link
Copy Markdown
Contributor

Improvements/Issues addressed:

  1. Add documentation on how to build for Windows, especially for ARM (with MSVC or clang)
  • See - llama.cpp/docs/build.md
  1. Fix, that building with MSVC breaks for Snapdragn X / Windows because MSVC does not support any C in-line Assembly for ARM (_asm_ directive) - fixes Bug: ggml-aarch64.c does not compile on Windows ARM64 with MSVC #8446
  • append "&& ! ((defined(_MSC_VER)) && ! defined(clang))" before each _asm_. Clang on Windows masquerades as MSCV, therefore the strange conditional - that it must not be a MSVC which is not clang.

ToDo in future fixes for Snapdragon X on Windows and not addressed by this PR:

P.S: This is my first PR ever, and with the help of chatGPT as tutor. Please have mercy on me, if I misunderstood things.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Compilation issues documentation Improvements or additions to documentation ggml changes relating to the ggml tensor library for machine learning Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ggml-aarch64.c does not compile on Windows ARM64 with MSVC

6 participants