Repository navigation
arg : bring back missing ifdef - #9411
Merged
Merged
Conversation
2 of 4 tasks
slaren
approved these changes
Sep 10, 2024
slaren
left a comment
slaren
left a comment
Member
There was a problem hiding this comment.
Truthfully these checks are very outdated and other backends now support these settings. Even if not 100% accurate, it would probably be better to replace these checks with a call to llama_supports_gpu_offload.
Collaborator
Author
|
Thanks for the info! I was also wondering if it works on RPC backend. The |
dsx1986
pushed a commit
to dsx1986/llama.cpp
that referenced
this pull request
Oct 29, 2024
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
my-other-github-account
pushed a commit
to my-other-github-account/llama.cpp
that referenced
this pull request
May 15, 2026
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
AlexiAlp
pushed a commit
to minghaop/llama.cpp
that referenced
this pull request
Jun 2, 2026
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
AlexiAlp
pushed a commit
to minghaop/llama.cpp
that referenced
this pull request
Jun 2, 2026
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
fukuro-kun
pushed a commit
to fukuro-kun/fukuro-llama-cpp-turboquant
that referenced
this pull request
Jul 5, 2026
* arg : bring back missing ifdef * replace with llama_supports_gpu_offload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref comment: #9388 (review)
GGML_USE_CUDA_SYCLis not used anywhere, so I remove that too