Release git-cas v6.5.4 - #101
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR prepares the v6.5.4 release candidate by documenting batched workspace page retention, updating package and release metadata, adding release notes and upgrade guidance, recording candidate evidence, and extending documentation validation tests. Changesv6.5.4 Release Candidate
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@UPGRADING.md`:
- Around line 12-15: Update the putBatch() example in UPGRADING.md to introduce
sources before it is used, using a representative pages/input collection
declaration so the example can be copied and run without undefined variables.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 80cc99ed-28c1-4354-b371-990be71c1d92
📒 Files selected for processing (15)
BEARING.mdCHANGELOG.mdREADME.mdROADMAP.mdSTATUS.mdUPGRADING.mddocs/design/0054-batched-page-retention/batched-page-retention.mddocs/design/0054-batched-page-retention/witness/release-candidate.mddocs/releases/v6.5.4.mdjsr.jsonpackage.jsonsrc/package-version.jstest/unit/docs/package-docs.test.jstest/unit/docs/release-state.test.jstest/unit/docs/release-truth.test.js
📜 Review details
🧰 Additional context used
📓 Path-based instructions (6)
docs/design/**
📄 CodeRabbit inference engine (AGENTS.md)
Use
docs/design/directory for durable design contracts and proof plans
Files:
docs/design/0054-batched-page-retention/witness/release-candidate.mddocs/design/0054-batched-page-retention/batched-page-retention.md
STATUS.md
📄 CodeRabbit inference engine (AGENTS.md)
Use
STATUS.mdas a compact snapshot of release and runtime truth
Files:
STATUS.md
README.md
📄 CodeRabbit inference engine (AGENTS.md)
Use
README.mdas the public front door, core value prop, and quick start documentation
Files:
README.md
ROADMAP.md
📄 CodeRabbit inference engine (AGENTS.md)
Use
ROADMAP.mdas a signpost to the GitHub release tracker
Files:
ROADMAP.md
BEARING.md
📄 CodeRabbit inference engine (AGENTS.md)
Use
BEARING.mdto document current execution gravity and active tensions
Files:
BEARING.md
CHANGELOG.md
📄 CodeRabbit inference engine (AGENTS.md)
Use
CHANGELOG.mdto record the historical truth of merged behavior
Files:
CHANGELOG.md
🧠 Learnings (3)
📚 Learning: 2026-07-13T17:00:46.222Z
Learnt from: flyingrobots
Repo: git-stunts/git-cas PR: 65
File: src/domain/helpers/isCanonicalCollectionKey.js:21-35
Timestamp: 2026-07-13T17:00:46.222Z
Learning: In git-stunts/git-cas, the codebase is intended to run on multiple JavaScript runtimes (Node, Bun, and Deno), not just Node. During code review, don’t suggest replacing existing portable helper logic with newer Node-only built-ins (e.g., Node 20+ APIs like `String.prototype.isWellFormed()`) unless the change preserves Bun/Deno compatibility (via portable/polyfill implementations or safe runtime gating). If a file includes manual implementations (such as `src/domain/helpers/isCanonicalCollectionKey.js`), treat them as intentional to avoid requiring a higher host built-in baseline.
Applied to files:
src/package-version.js
📚 Learning: 2026-02-28T19:21:13.982Z
Learnt from: flyingrobots
Repo: git-stunts/git-cas PR: 15
File: test/unit/domain/services/CasService.envelope.test.js:326-330
Timestamp: 2026-02-28T19:21:13.982Z
Learning: In fuzz tests for cryptographic operations, use a seeded PRNG (e.g., xorshift32) for control-flow variables such as plaintext size selection and recipient index selection to ensure reproducibility. Continue to use randomBytes() for cryptographic keys and nonces to preserve realistic randomness and avoid security anti-patterns. This guideline applies to test files that perform fuzz testing of crypto logic; implement a consistent seed setup (e.g., fixed seed in test initialization) and document the rationale to enable deterministic replays across runs.
Applied to files:
test/unit/docs/release-truth.test.jstest/unit/docs/package-docs.test.jstest/unit/docs/release-state.test.js
📚 Learning: 2026-03-30T19:53:48.000Z
Learnt from: flyingrobots
Repo: git-stunts/git-cas PR: 29
File: docs/design/TR-010-planning-index-consistency-review.md:121-131
Timestamp: 2026-03-30T19:53:48.000Z
Learning: In this repo, CHANGELOG.md entries should be user-facing and descriptive (bullet points) rather than cycle-ID headings (e.g., use a phrase like “Planning-index consistency review” instead of a “TR-010 — …” heading). When searching the changelog, don’t rely on grepping for cycle IDs (e.g., “TR-010”) because it may cause false negatives; search for the descriptive keywords/phrases from the bullet entries instead.
Applied to files:
CHANGELOG.md
🪛 LanguageTool
docs/design/0054-batched-page-retention/witness/release-candidate.md
[style] ~91-~91: Consider removing “of” to be more concise
Context: ...Gate Publication remains blocked until all of the following are true: 1. the versioned c...
(ALL_OF_THE)
🔇 Additional comments (14)
docs/design/0054-batched-page-retention/batched-page-retention.md (1)
10-10: LGTM!Also applies to: 300-307
docs/design/0054-batched-page-retention/witness/release-candidate.md (1)
1-103: LGTM!docs/releases/v6.5.4.md (1)
1-48: LGTM!src/package-version.js (1)
1-1: LGTM!test/unit/docs/package-docs.test.js (1)
21-21: LGTM!Also applies to: 96-96
test/unit/docs/release-state.test.js (1)
6-8: LGTM!Also applies to: 34-56, 137-149, 275-305
test/unit/docs/release-truth.test.js (1)
281-295: LGTM!BEARING.md (1)
17-17: LGTM!Also applies to: 75-83, 139-147
CHANGELOG.md (1)
10-17: LGTM!README.md (1)
52-52: LGTM!Also applies to: 222-223
ROADMAP.md (1)
44-44: LGTM!Also applies to: 53-56
STATUS.md (1)
4-5: LGTM!Also applies to: 21-25, 142-142
jsr.json (1)
3-3: LGTM!package.json (1)
3-3: LGTM!Also applies to: 43-43
Linked Issue
Design / Proof
docs/design/0054-batched-page-retention/batched-page-retention.mddocs/design/0054-batched-page-retention/witness/release-candidate.mdValidation
pnpm run release:verify # PASS 14/14; 6,844 observed testsRelease Impact