Skip to content

decode SARIF URIs when filtering diff-informed alerts - #4274

Closed
akream wants to merge 2 commits into
mainfrom
akream-fix-diff-informed-sarif-paths
Closed

akream wants to merge 2 commits into
mainfrom
akream-fix-diff-informed-sarif-paths

Conversation

@akream

@akream akream commented Oct 28, 2026

Copy link
Copy Markdown

Refs github/code-scanning#25543. Diff-informed filtering compared raw diff API paths with percent-encoded SARIF URIs, excluding alerts in changed files with encoded names. Decode SARIF paths before comparison; tests cover special and non-ASCII characters, literal percent signs, and malformed escapes without changing line filtering.

Risk assessment

For internal use only. Please select the risk level of this change:

  • High risk: Changes are not fully under feature flags, have limited visibility and/or cannot be tested outside of production.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Third-party analyses - The changes affect the upload-sarif action.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - Covers encoded spaces, Unicode and punctuation, literal percent signs, malformed URI fallback, and unmatched paths.
  • Other - Local build, targeted ESLint, and change-note validation.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Other - No new telemetry is added; users can report missing alerts through workflow results and support channels.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

akream and others added 2 commits October 28, 2026 12:06
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b1744ae3-8204-4901-8dc7-16368fd6d865
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b1744ae3-8204-4901-8dc7-16368fd6d865
@github-actions github-actions Bot added the size/S Should be easy to review label Oct 28, 2026
@akream akream closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant