Repository navigation
Contributing back to upstream dependencies? #106
Description
Activity
Hi @karlhorky, appreciate the feedback.
The changes for both dependencies are focused on adding/improving the native addon prebuilds.
For node-pty, the upstream change is microsoft/node-pty#794 waiting on help from @rzhao271 updating the publishing pipeline 🙏
For keytar, the changes are similar between keytar-forked and keytar-forked-forked (diff). However, I don't have a PR open for it because as you mention the original package is unmaintained. We are working on moving the latest to a new package to take ownership and maintenance. Will update here on that.
Thank you for raising!
Reacted by Karl HorkyReacted by Karl HorkyReacted by Karl HorkyAmazing, thanks for the quick response and plan!
@RyanHecht why did you close this issue?
There is a plan above, and microsoft/node-pty#804 has been merged as part of it, but is all of the work to contribute to these upstream dependencies and the new keytar package done already? @devm33 mentioned above that he will write an update here about that.
Describe the feature or problem you'd like to solve
Contribute improvements back to upstream dependencies
Proposed solution
Copilot CLI has two dependencies,
@devm33/node-ptyandkeytar-forked-forkedhttps://www.npmjs.com/package/@github/copilot?activeTab=dependencies@devm33/node-pty)keytar(originalkeytaris unmaintained).keytar-forked(https://github.com/shiftkey/node-keytar by @shiftkey) is one option, but it only has 600 downloads per weekThis would enable Copilot CLI to also give back to the open source ecosystem.
cc @devm33
Example prompts or workflows
--
Additional context
--