Repository navigation
Return the context error when cancelled during parity - #157
Merged
Merged
Conversation
This was referenced Oct 11, 2026
Closed
nodeselector
marked this pull request as ready for review
October 11, 2026 22:40
There was a problem hiding this comment.
🟡 Changes recommended
Dependabot-proxy parity errors can still mask context.Canceled because the ordinary error is checked first.
1 open finding
What changed in this PR
Ensures parity-check cancellation is propagated instead of producing a normal result.
Changes:
- Checks context cancellation after parity.
- Adds cancellation-aware test helpers and regression coverage.
| File | Description |
|---|---|
internal/pipeline/run.go |
Propagates parity cancellation. |
cmd/gh-actions-lock/parity_test.go |
Tests cancellation during ancestry checks. |
cmd/gh-actions-lock/command_test.go |
Adds context-aware command execution helper. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nodeselector
force-pushed
the
nodeselector-prerc-6-parity-cancel
branch
from
October 11, 2026 22:53
7613ea4 to
8fbb4a1
Compare
nodeselector
force-pushed
the
nodeselector-prerc-5-verify-ref-history
branch
2 times, most recently
from
October 11, 2026 23:23
d06f9c0 to
3b7dcb1
Compare
Ancestry checks and diagnosis can see a cancelled context and return inconclusive results; without the check Run reported them as a normal result.
Behind the proxy a cancelled history lookup came back as an inconclusive ancestry error, which Run returned ahead of the context error.
nodeselector
changed the base branch from
nodeselector-prerc-5-verify-ref-history
to
main
October 11, 2026 23:26
nodeselector
force-pushed
the
nodeselector-prerc-6-parity-cancel
branch
from
October 11, 2026 23:26
8fbb4a1 to
fcc1324
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the run is cancelled during the parity check, it now reports the cancellation instead of continuing as if it had succeeded.
Part 6 of 6 (#152 → #157). Previous: #156