Repository navigation
fix(ci): preserve NVX phase 0 probe failures - #8724
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b7bb21d-a74b-4061-b1d0-ae2a18df7a8c
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes correctly address the observed failure mode and the generated lock file matches the workflow source.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents expected NVX probe failures from aborting evidence collection and ensures diagnostics are retained.
Changes:
- Temporarily disables fail-fast behavior during probes, restoring it for summary generation.
- Uploads Phase 0 evidence unconditionally.
- Regenerates the compiled workflow.
| File | Description |
|---|---|
.github/workflows/nvx-phase-0-feasibility.md |
Preserves probe failures and uploads evidence. |
.github/workflows/nvx-phase-0-feasibility.lock.yml |
Applies the source changes to the generated workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bash -estepValidation
gh aw compile nvx-phase-0-feasibility --strict --validate --actionlint --shellcheckFixes the failure mode observed in run 35279656609.