Repository navigation
Conversation
Copilot
AI
changed the title
[WIP] Fix cloud-hypervisor version probe failing with undefined exit code
Surface exec-bit/KVM diagnostics for opaque Cloud Hypervisor version-probe failures
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cloud Hypervisor
--versionpreflight probe could fail with"... --version" exited with code undefined, giving no indication of the real cause (OOM kill, missing exec bit, unsupported CPU/KVM features).Root cause
runVersion()insrc/cloud-hypervisor/preflight.tsalready capturedsignalCode/spawn errno for undefined exit codes, but the resulting error message still didn't point at a likely cause — just the raw signal/errno.Changes
New
describeVersionProbeFailure()helper: on the existing failure paths only (execa throwing, ambiguous undefined exit code, signal-killed exit), checks:/dev/kvmis read/write accessible (missing KVM support or unsupported CPU virtualization features)and appends a
Possible causes: ...hint to the thrown error.No change to trust/ordering guarantees: the helper runs strictly after a failure is already detected, so it cannot mask, skip, or reorder any of the existing fail-closed artifact/digest/host checks.
Example resulting error for a signal-killed probe: