Repository navigation
docs: define NVX one-shot security design - #8763
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b7bb21d-a74b-4061-b1d0-ae2a18df7a8c
Contributor
Documentation PreviewDocumentation has been built for this PR. To view locally:
Built from commit 5edfe25 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Outcome validation can accept incomplete teardown reports and misclassify a legitimate guest exit code 125.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Defines the Phase 1 security contract for an opt-in, one-shot NVX backend and aligns Phase 0 feasibility probes with that model.
Changes:
- Documents NVX isolation, artifact trust, networking, outcomes, and cleanup requirements.
- Replaces managed-session probes with independent Codex and Copilot one-shot runs.
- Adds structured cleanup evidence and regenerates the workflow lock.
| File | Description |
|---|---|
docs/sbx-integration.md |
Links the NVX security design. |
docs/nvx-security-design.md |
Defines the Phase 1 security contract. |
.github/workflows/nvx-phase-0-feasibility.md |
Updates probes for one-shot execution and cleanup. |
.github/workflows/nvx-phase-0-feasibility.lock.yml |
Regenerates the compiled workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b7bb21d-a74b-4061-b1d0-ae2a18df7a8c
Contributor
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
Require exact teardown keys and report outcome categories without guessing from status codes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b7bb21d-a74b-4061-b1d0-ae2a18df7a8c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines the Phase 1 security contract for an opt-in NVX primary-agent backend using one-shot execution only.
sandbox exec, TTYs, VM reuse, resume, and snapshot/restore from the initial backend.sandbox runwithout managed-session gating.Validation
gh aw compile nvx-phase-0-feasibility --strict --validate --actionlint --shellchecknpx --no-install markdownlint-cli2 docs/nvx-security-design.md docs/sbx-integration.md .github/workflows/nvx-phase-0-feasibility.md