Repository navigation
Persist Schema & Spec Sync state across runs - #9262
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The source, generated workflow, and regression coverage consistently implement durable watermark persistence.
Review effort: Balanced
Findings: None
What changed in this PR
Moves Schema & Spec Sync’s watermark to durable repo memory, resolving #9258.
Changes:
- Replaces date-scoped cache memory with
memory/schema-sync. - Treats missing state as an expected seven-day cold start.
- Adds regression tests and regenerates the workflow lock.
| File | Description |
|---|---|
.github/workflows/schema-sync.md |
Configures durable state and cold-start behavior. |
.github/workflows/schema-sync.lock.yml |
Adds generated repo-memory clone/push jobs. |
scripts/ci/schema-sync-workflow.test.ts |
Verifies source and lock configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
✅ Copilot review passed with no inline comments. @copilot Add the |
|
| Metric | Base | PR | Delta |
|---|---|---|---|
| Lines | 92.71% | 92.71% | ➡️ +0.00% |
| Statements | 91.22% | 91.22% | ➡️ +0.00% |
| Functions | 89.30% | 89.30% | ➡️ +0.00% |
| Branches | 84.29% | 84.28% | 📉 -0.01% |
📁 Per-file Coverage Changes (2 files)
| File | Lines (Before → After) | Statements (Before → After) |
|---|---|---|
src/nvx/one-shot-adapter.ts |
83.5% → 82.9% (-0.60%) | 80.3% → 79.8% (-0.56%) |
src/log-directory-setup.ts |
96.2% → 100.0% (+3.78%) | 96.3% → 100.0% (+3.71%) |
Coverage comparison generated by scripts/ci/compare-coverage.ts
|
@copilot merge main |
…ma-spec-sync Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Merged |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
The workflow’s date-scoped cache could not restore its watermark on the next weekday run, triggering
cache_memory_missdespite a supported cold-start fallback.repo-memorybranch.