Skip to content

fix: build before running tests - #9517

Merged
lpcox merged 2 commits into
mainfrom
fix-npm-test-cloud-hypervisor-preflight
Oct 6, 2026
Merged

lpcox merged 2 commits into
mainfrom
fix-npm-test-cloud-hypervisor-preflight

Conversation

@lpcox

@lpcox lpcox commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Build TypeScript output before invoking Jest via npm test.
  • Fixes the clean-checkout Cloud Hypervisor host preflight test failure caused by its runtime dependency on dist/.

Validation

  • npm test — passed (435 suites, 7,405 tests; 22 skipped).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 6, 2026 22:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Other documented test entry points still fail on clean checkouts when dist/ is absent.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Builds TypeScript output before the default Jest suite to satisfy tests requiring dist/.

Changes:

  • Updates npm test to run the build first.
File Description
package.json Adds the build prerequisite to the default test script.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json Resolved
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 92.92% 92.93% 📈 +0.01%
Statements 91.39% 91.40% 📈 +0.01%
Functions 89.98% 89.98% ➡️ +0.00%
Branches 85.02% 85.03% 📈 +0.01%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/log-directory-setup.ts 96.8% → 100.0% (+3.18%) 96.9% → 100.0% (+3.13%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ Copilot review passed with no inline comments.

@lpcox Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

@lpcox

lpcox commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot address review feedback

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@copilot address review feedback

Updated the Jest entry points so each path builds dist/ first; test:all inherits this through unit and integration. Addressed in 6d4bb8c.

@lpcox
lpcox merged commit 4790477 into main Oct 6, 2026
30 checks passed
@lpcox
lpcox deleted the fix-npm-test-cloud-hypervisor-preflight branch October 6, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants