Skip to content

[log] Add debug logging to difc/resource.go #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[log] Add debug logging to difc/resource.go #1607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/difc/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
package difc

import "github.com/github/gh-aw-mcpg/internal/logger"

var logResource = logger.New("difc:resource")

// Resource represents an external system with label requirements (deprecated - use LabeledResource)
type Resource struct {
Description string
Expand Down Expand Up @@ -102,8 +106,10 @@ type LabeledItem struct {
}

func (c *CollectionLabeledData) Overall() *LabeledResource {
logResource.Printf("CollectionLabeledData.Overall: aggregating labels for %d items", len(c.Items))
// Aggregate labels from all items - most restrictive
if len(c.Items) == 0 {
logResource.Print("CollectionLabeledData.Overall: empty collection, returning empty labels")
return NewLabeledResource("empty collection")
}

Expand Down Expand Up @@ -138,8 +144,11 @@ type FilteredCollectionLabeledData struct {
}

func (f *FilteredCollectionLabeledData) Overall() *LabeledResource {
logResource.Printf("FilteredCollectionLabeledData.Overall: accessible=%d, filtered=%d, reason=%s",
len(f.Accessible), len(f.Filtered), f.FilterReason)
// Only aggregate labels from accessible items
if len(f.Accessible) == 0 {
logResource.Print("FilteredCollectionLabeledData.Overall: no accessible items, returning empty labels")
return NewLabeledResource("empty filtered collection")
}

Expand All @@ -155,6 +164,8 @@ func (f *FilteredCollectionLabeledData) Overall() *LabeledResource {
}

func (f *FilteredCollectionLabeledData) ToResult() (interface{}, error) {
logResource.Printf("FilteredCollectionLabeledData.ToResult: returning %d accessible items (filtered=%d)",
len(f.Accessible), len(f.Filtered))
// Return only accessible items
result := make([]interface{}, 0, len(f.Accessible))
for _, item := range f.Accessible {
Expand Down